[STAL-1686] Follow-up for handling rules marked as is_testing
#349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
When releasing version 0.3.3 of the analyzer, we started having 422s. This was due to the front-end not sending
is_testing
ifis_testing
was unset. The IDE integration would have the same issue. This PR does the following to address this issue:is_testing
is empty in the Rule struct.is_testing
field from the ServerRule struct.test-production-rules.py
integration test to expose the error if it fails, rather than justreturned non-zero exit status 1.
What is your solution?
Testing
Followed the procedure here: #339