This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
Fix performance issue in quantile.WeighSummary #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LotharSee
reviewed
Apr 9, 2018
quantile/weighted.go
Outdated
| rand.Seed(7337) | ||
| for i := 0; i < 100; i++ { | ||
| randomFloats = append(randomFloats, rand.Float64()) | ||
| } |
There was a problem hiding this comment.
May this be more efficient?
randomFloats = make([]float64, 100)
for i := 0; i < 100; i++ {
randomFloats[i] = rand.Float64()
}
LotharSee
approved these changes
Apr 9, 2018
LotharSee
reviewed
Apr 9, 2018
quantile/weighted.go
Outdated
| func init() { | ||
| // generate a list of guaranteed random numbers for the probabilistic round | ||
| randomFloats = make([]float64, 100) | ||
| rand.Seed(7337) |
There was a problem hiding this comment.
Nitpick: to not affect the global rand seed, we could use r:= New(NewSource(7337)) / r.Float64().
LotharSee
approved these changes
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rand.Seed(7337)was called on every call toprobabilisticRoundwhich was both incorrect and very slow since it was equivalent to having a single hard coded float to do all the roundings and calls torand.Seedare very expensive.