This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
config: use Python environment as fallback to compute hostname #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a regression where the Python environment was removed from the host acquiring process. The Python environment is needed because it uses a Datadog-specific library which covers for scenarios such as GCE, EC2, Docker etc. for hostname retrieval.
palazzem
approved these changes
Jul 12, 2018
gbbr
added a commit
that referenced
this pull request
Jul 12, 2018
This change fixes a regression where the Python environment was removed from the host acquiring process. The Python environment is needed because it uses a Datadog-specific library which covers for scenarios such as GCE, EC2, Docker etc. for hostname retrieval.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a regression where the Python environment was removed
from the host acquiring process in #435
The Python environment is needed because it uses a Datadog-specific
library which covers for scenarios such as GCE, EC2, Docker etc. for
hostname retrieval.