Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

Favor passing small value copy over pointer #467

Merged
merged 1 commit into from Sep 5, 2018
Merged

Favor passing small value copy over pointer #467

merged 1 commit into from Sep 5, 2018

Conversation

p-lambert
Copy link
Member

@p-lambert p-lambert commented Sep 4, 2018 •
edited

This PR just simplifies part of the agent code by passing a slice value instead of a pointer.

bmermet
bmermet approved these changes Sep 5, 2018
View reviewed changes
Copy link

@bmermet bmermet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@p-lambert p-lambert merged commit cf995d1 into master Sep 5, 2018
@gbbr gbbr mentioned this pull request Sep 10, 2018
Closed
@gbbr gbbr deleted the pedro/simplify-sublayer-code branch September 11, 2018 07:12
@gbbr gbbr added this to the 6.5.0 milestone Sep 11, 2018
p-lambert added a commit that referenced this pull request Sep 21, 2018
@p-lambert
Revert "Merge pull request #467 from DataDog/pedro/simplify-sublayer-…
1d1e8c4 
…code"

This reverts commit cf995d1, reversing
changes made to 69f6de4.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmermet bmermet bmermet approved these changes

@gbbr gbbr Awaiting requested review from gbbr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@p-lambert @bmermet @gbbr