[api] adding basic tornado-based API for status reporting #18
Conversation
| @@ -517,57 +529,67 @@ def __init__(self, hostname, interval=1.0, expiry_seconds=300, | |||
| histogram_percentiles, | |||
| utf8_decoding | |||
| ) | |||
| self.sources = defaultdict(set) | |||
There was a problem hiding this comment.
If I get it right, sources allow use to group context/metric by checks to have stats on them ?
Wouldn't it be simpler for the AgentCheck class to gather statistics on his run and send them at the end of the run ? It could be done by the collector.
I don't think this should be the job of the aggregator. It extends its API and the data is mainly about checks so checks should be in charge of it.
What do you think ?
There was a problem hiding this comment.
Let me think about it, I kind of wanted a uniform-ish interface for the aggregators so I could do something similar for dogstatsd as well - something that programmatically was consistent with what we may have to do on the bucketed aggregator. But I see your point....
There was a problem hiding this comment.
Does is make sens to have stats on the number of context for dogstatsd ?
|
Merging after rebase, created issue to track pending discussion regarding stats book-keeping refactor. |
No description provided.