Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for SLOs #453

Merged
merged 15 commits into from Oct 11, 2019
Merged

add support for SLOs #453

merged 15 commits into from Oct 11, 2019

Conversation

platinummonkey
Copy link
Contributor

Adds support for Service Level Objectives

MA-434

@zippolyte
Copy link
Contributor

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@platinummonkey
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy

@nmuesch
Copy link
Contributor

nmuesch commented Oct 3, 2019

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@platinummonkey
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy

@platinummonkey
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy

@gzussa
Copy link
Contributor

gzussa commented Oct 8, 2019

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@platinummonkey
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy

@platinummonkey
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy

@zippolyte
Copy link
Contributor

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Also, it might be worth it adding some dogshell tests as well

datadog/api/service_level_objectives.py Outdated Show resolved Hide resolved
datadog/dogshell/service_level_objective.py Show resolved Hide resolved
datadog/dogshell/service_level_objective.py Outdated Show resolved Hide resolved
datadog/dogshell/service_level_objective.py Show resolved Hide resolved
datadog/dogshell/service_level_objective.py Show resolved Hide resolved
datadog/dogshell/service_level_objective.py Show resolved Hide resolved
datadog/dogshell/service_level_objective.py Outdated Show resolved Hide resolved
datadog/dogshell/service_level_objective.py Outdated Show resolved Hide resolved
datadog/dogshell/service_level_objective.py Outdated Show resolved Hide resolved
@platinummonkey
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy

@platinummonkey
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy

@platinummonkey
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy

@ofek
Copy link
Contributor

ofek commented Oct 9, 2019

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@platinummonkey
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy

@platinummonkey
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@platinummonkey
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@platinummonkey
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test for some error scenarios here please 🙏 ?

@platinummonkey
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Thanks a lot for all this

@platinummonkey platinummonkey merged commit a3bce13 into DataDog:master Oct 11, 2019
@platinummonkey platinummonkey deleted the service-level-objectives branch October 11, 2019 16:20
dabcoder pushed a commit to dabcoder/datadogpy that referenced this pull request Oct 25, 2019
* add support for SLOs

* add suppress ApiError on base client for status codes to adapt to warnings-style errors for certain status codes

* add test for core client suppression

* compat for py3

* helper hack for py3 testing compat
dabcoder pushed a commit to dabcoder/datadogpy that referenced this pull request Nov 28, 2019
* add support for SLOs

* add suppress ApiError on base client for status codes to adapt to warnings-style errors for certain status codes

* add test for core client suppression

* compat for py3

* helper hack for py3 testing compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants