Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _return_raw_response to api module #461

Merged
merged 2 commits into from Oct 16, 2019
Merged

Add _return_raw_response to api module #461

merged 2 commits into from Oct 16, 2019

Conversation

zippolyte
Copy link
Contributor

Fixes #460

@zippolyte zippolyte requested a review from a team as a code owner October 11, 2019 09:17
@zippolyte
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test. 💯 However in this case, I wonder if it actually makes sense.

"""
Test all the default setting are properly set before calling initialize
"""
from datadog.api import (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really convinced by the usefulness of this test. It won't prevent anyone to not add settings in the init later. What do you think?

Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least, it checks default value so 🚢

@zippolyte zippolyte merged commit ebb8094 into master Oct 16, 2019
@zippolyte zippolyte deleted the hippo/rrr branch October 16, 2019 07:56
dabcoder pushed a commit to dabcoder/datadogpy that referenced this pull request Oct 25, 2019
dabcoder pushed a commit to dabcoder/datadogpy that referenced this pull request Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api_client.py imports non-existent field from api
3 participants