Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to send compressed payloads for metrics and distribution #466

Merged
merged 4 commits into from Oct 30, 2019

Conversation

zippolyte
Copy link
Contributor

Our API supports zlib compressed payloads on the series endpoint. Leverage this to help with issue #465

@zippolyte zippolyte requested a review from a team as a code owner October 22, 2019 14:47
@zippolyte
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zippolyte
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left one small note about tests. It also looks like the integration test suite isn't passing.

@@ -626,6 +622,33 @@ def test_data_type_support(self):
serie = dict(metric='metric.numerical', points=point)
self.submit_and_assess_metric_payload(serie)

def test_compression(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜 While we're here can we explicitly test for compression being False/the default to protect against regressions/the default behavior changing?

Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the additional tests!

@zippolyte
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zippolyte
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zippolyte zippolyte merged commit 62f058d into master Oct 30, 2019
@zippolyte zippolyte deleted the hippo/cp branch October 30, 2019 15:00
dabcoder pushed a commit to dabcoder/datadogpy that referenced this pull request Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants