Add test to check CfgNotFound exception #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabcoder
force-pushed
the
davidb/hostname-exception
branch
from
5cace2d
to
ec6504f
Compare
dabcoder
force-pushed
the
davidb/hostname-exception
branch
from
cc5227c
to
ded4cee
Compare
dabcoder
changed the title
nmuesch
approved these changes
Oct 31, 2019
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Nov 28, 2019
* Remove Exception warning if option is set to True too * Assess Exception not raised * Second warning is covered anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test to ensure the
CfgNotFoundis not raised whenhostname_from_configis set to false (and thus the second warning message is not emitted either).