Add back telemetry to Dogstatsd client #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fc09440.
hush-hush
added
the
changelog/Added
zippolyte
reviewed
Feb 11, 2020
hush-hush
changed the title
hush-hush
force-pushed
the
maxime/remove-namespace-telemetry
branch
2 times, most recently
from
3c49f86
to
65f757e
Compare
hush-hush
force-pushed
the
maxime/remove-namespace-telemetry
branch
from
65f757e
to
5928c8a
Compare
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zippolyte
approved these changes
Feb 19, 2020
zippolyte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR remove the namespace for the telemetry metric to avoid counting them as custom metrics.
We also only flush the telemetry once every 10s (by default) to mirror the behavior from other Dogstatsd clients.