Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enum for monitor types #544

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Add enum for monitor types #544

merged 2 commits into from
Mar 6, 2020

Conversation

zippolyte
Copy link
Contributor

What does this PR do?

Closes #99 by adding a class MonitorType with constants for the allowed values

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@zippolyte zippolyte added the changelog/Added Added features results into a minor version bump label Mar 6, 2020
@zippolyte zippolyte requested a review from a team as a code owner March 6, 2020 09:41
@zippolyte zippolyte merged commit 0ac4103 into master Mar 6, 2020
@zippolyte zippolyte deleted the hippo/mt branch March 6, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzussa gzussa gzussa approved these changes

Assignees
No one assigned
Labels
changelog/Added Added features results into a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monitor types as values
2 participants
@zippolyte @gzussa