Fix Synthetics delete_test parameter name #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change doc string and error message to use the correct name for the `public_ids` parameter of `delete_test`.
nmuesch
added
the
changelog/Fixed
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Thanks @jonathan-hosmer This looks good to me, mind just updating the PR title to reflect what this fixes (it'll get used in the changelog when we release) |
jonathan-hosmer
changed the title
|
Updated.
… On Sep 24, 2020, at 6:34 PM, Nicholas Muesch ***@***.***> wrote:
Thanks @jonathan-hosmer This looks good to me, mind just updating the PR title to reflect what this fixes (it'll get used in the changelog when we release)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
jirikuncar
approved these changes
Sep 28, 2020
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
therve
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change doc string and error message to use the correct name for the
public_idsparameter ofdelete_test.What does this PR do?
Correct an error message to use the proper name of a parameter.
Description of the Change
Change doc string and error message to use the correct name for the
public_idsparameter ofdelete_test.Alternate Designs
N/A
Possible Drawbacks
N/A
Verification Process
Run code using incorrect type for parameter to ensure error message displays correctly.
Additional Notes
Also updated documentation here: DataDog/documentation#8640
Release Notes
Fix
Syntheticsdelete_testparameter name in docstring andApiErrortext.Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.