Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apt] Only create dd-agent group if it doesn't already exist #89

Merged
merged 1 commit into from
Sep 5, 2016
Merged

[apt] Only create dd-agent group if it doesn't already exist #89

merged 1 commit into from
Sep 5, 2016

Conversation

suhasgaddam
Copy link
Contributor

It looks like parentheses are needed for the appropriate order of operations.

@olivielpeau olivielpeau added this to the 5.9.0 milestone Sep 5, 2016
@olivielpeau
Copy link
Member

Nice catch @suhasgaddam, thanks! You're right in sh the && and || operators have the same precedence, so the parentheses are needed here.

FYI this change only affects the creation of the dd-agent group, I'll update the PR title accordingly. Also, the addgroup command returns 0 when the group already exists so this mistake in the script didn't have any user impact.

Merging, thanks again!

@olivielpeau olivielpeau changed the title Only create dd-agent group and/or user if they don't already exist [apt] Only create dd-agent group if it doesn't already exist Sep 5, 2016
@olivielpeau olivielpeau added the bug label Sep 5, 2016
@olivielpeau olivielpeau merged commit 55d0ea8 into DataDog:master Sep 5, 2016
@suhasgaddam suhasgaddam mentioned this pull request Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants