[elastic]❌ cluster_name tag from service checks

Remove `cluster_name` tag from service checks.
DataDog · Sep 8, 2016 · d4c3d76 · d4c3d76
1 parent 0f20aa4
commit d4c3d76
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/checks.d/elastic.py b/checks.d/elastic.py
@@ -410,7 +410,6 @@ def check(self, instance):
             # retreive the cluster name from the data, and append it to the
             # master tag list.
             config.tags.append("cluster_name:{}".format(stats_data['cluster_name']))
-            config.service_check_tags.append("cluster_name:{}".format(stats_data['cluster_name']))
         self._process_stats_data(nodes_url, stats_data, stats_metrics, config)
 
         # Load clusterwise data

diff --git a/tests/checks/integration/test_elastic.py b/tests/checks/integration/test_elastic.py
@@ -411,7 +411,7 @@ def test_check(self):
                     self.assertMetric(
                         m_name, tags=m_tags, count=1, hostname=hostname)
 
-        good_sc_tags = ['host:localhost', 'port:{0}'.format(port)] + cluster_tag
+        good_sc_tags = ['host:localhost', 'port:{0}'.format(port)]
         bad_sc_tags = ['host:localhost', 'port:{0}'.format(bad_port)]
 
         self.assertServiceCheckOK('elasticsearch.can_connect',