Skip to content

Commit

Permalink
[wheel] Don't spam logs with exceptions when checks aren't wheels (#3620
Browse files Browse the repository at this point in the history
)

We always try to load the checks as wheel-installed checks, but it's
not an error if they're installed otherwise, so avoid logging with
exception level.
  • Loading branch information
olivielpeau committed Dec 29, 2017
1 parent 180a717 commit e49cbce
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion config.py
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,8 @@ def _get_check_module(check_name, check_path, from_site=False):
check_module = import_module("datadog_checks.{}".format(check_name))
except ImportError as e:
error = e
log.exception('Unable to import check module %s from site-packages' % check_name)
# Log at debug level since this code path is expected if the check is not installed as a wheel
log.debug('Unable to import check module %s from site-packages: %s', check_name, e)
else:
try:
check_module = imp.load_source('checksd_%s' % check_name, check_path)
Expand Down

0 comments on commit e49cbce

Please sign in to comment.