bytes_outstanding metric is misleading

This value is not a value in bytes. Fix #1383 We should remove it in a major version of the agent but for now, let’s add a new metric name for this value.
DataDog · Mar 17, 2015 · f74256d · f74256d
1 parent da7399f
commit f74256d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/checks.d/zk.py b/checks.d/zk.py
@@ -175,7 +175,10 @@ def parse_stat(self, buf):
 
         # Outstanding: 0
         _, value = buf.readline().split(':')
+        # Fixme: This metric name is wrong. It should be removed in a major version of the agent
+        # See https://github.com/DataDog/dd-agent/issues/1383
         metrics.append(('zookeeper.bytes_outstanding', long(value.strip())))
+        metrics.append(('zookeeper.outstanding_requests', long(value.strip())))
 
         # Zxid: 0x1034799c7
         _, value = buf.readline().split(':')

diff --git a/tests/test_zookeeper.py b/tests/test_zookeeper.py
@@ -86,6 +86,7 @@ def test_zk_stat_parsing_lt_v344(self):
             ('zookeeper.bytes_sent',                0L),
             ('zookeeper.connections',                6),
             ('zookeeper.bytes_outstanding',         0L),
+            ('zookeeper.outstanding_requests',      0L),
             ('zookeeper.zxid.epoch',                 1),
             ('zookeeper.zxid.count',          55024071),
             ('zookeeper.nodes',                    487L),
@@ -115,6 +116,7 @@ def test_zk_stat_parsing_gte_v344(self):
             ('zookeeper.bytes_sent',                0L),
             ('zookeeper.connections',                1),
             ('zookeeper.bytes_outstanding',         0L),
+            ('zookeeper.outstanding_requests',      0L),
             ('zookeeper.zxid.epoch',                 1),
             ('zookeeper.zxid.count',          55024071),
             ('zookeeper.nodes',                    487L),