Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[process] Re-enable check on Windows #1883

Merged
merged 1 commit into from
Sep 2, 2015

Conversation

elafarge
Copy link
Contributor

@elafarge elafarge commented Sep 2, 2015

The check is working agian since 5.4.0 but it was never re-enabled in
the GUI. Here's the commit that does it :)

The check is working agian since 5.4.0 but it was never re-enabled in
the GUI. Here's the commit that does it :)
@remh
Copy link
Contributor

remh commented Sep 2, 2015

can you post the link to the PR / commit that fixes it please ?

@elafarge
Copy link
Contributor Author

elafarge commented Sep 2, 2015

Sure. The fix was actually brought by @LeoCavaille : 774e97b .

@elafarge
Copy link
Contributor Author

elafarge commented Sep 2, 2015

(Oh and I fforgot to mention but this has been tested over user-level processes, admin-level processes and system-level processes on Windows 10 - using the MSI installation - everything's working there).

@remh
Copy link
Contributor

remh commented Sep 2, 2015

👍

remh added a commit that referenced this pull request Sep 2, 2015
…n-windows

[process] Re-enable check on Windows
@remh remh merged commit 892287e into master Sep 2, 2015
@remh remh added this to the 5.5.0 milestone Sep 2, 2015
@remh remh deleted the etienne/renable-process-check-on-windows branch May 3, 2016 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants