Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak found on memcache-enabled agents #278

Closed
alq666 opened this issue Nov 26, 2012 · 5 comments
Closed

Memory leak found on memcache-enabled agents #278

alq666 opened this issue Nov 26, 2012 · 5 comments
Assignees
@clofresh
Labels
checks

Comments

@alq666
Copy link
Member

alq666 commented Nov 26, 2012

500MB of anon space used by the collector: https://gist.github.com/f7973df8c680ed3776d8
@ghost ghost assigned alq666 Nov 26, 2012
@ghost ghost assigned clofresh Dec 5, 2012
@clofresh
Copy link
Contributor

clofresh commented Dec 5, 2012

How many memcache instances is the check connecting to?

@bciceron
Copy link

bciceron commented Dec 5, 2012

snippet of ddog agent config
memcache_instance_1: localhost:11211:memcached_11211
memcache_instance_2: localhost:11212:memcached_11212
memcache_instance_3: localhost:11213:memcached_11213

each memcached launched with
/usr/bin/memcached -u memcached -d -t 8 -m 39936 -p 11213 -P /var/run/memcached/memcached-11213.pid -U 0

clofresh pushed a commit that referenced this issue Dec 27, 2012
fix memcache memory leak (#278)
8c62995 
Apparently the closure used in parsing the memcache config is
leaving behind some uncollectable objects on each run. Replaced
it with a while loop.
clofresh pushed a commit that referenced this issue Dec 27, 2012
fix memcache memory leak (#278)
8d114db 
Apparently the closure used in parsing the memcache config is
leaving behind some uncollectable objects on each run. Replaced
it with a while loop.
clofresh pushed a commit that referenced this issue Dec 27, 2012
monkeypatch to fix memory leak in memcache library
d3bbd1f 
Instantiating a memcache.Client object will create a memcache._Host
object that stores the debuglog method of the Client object. That
_Host object gets stored in the original Client object, presumably
causing that memory to get lost in time and space forever. The
workaround is to set Client.debuglog to None so that _Host won't
try to store anything, avoiding the cyclic reference. (#278)
@clofresh
Copy link
Contributor

Fixed in 3.4.3

@clofresh
Copy link
Contributor

clofresh commented Jan 2, 2013

f96ef9026cc4353290b3407a45a12c34be9aecb2
Graph of the usable system memory for a memcache host before and after the fix.

@olidb2
Copy link
Member

olidb2 commented Jan 2, 2013

Nice one!

On Wed, Jan 2, 2013 at 10:56 AM, Carlo Cabanilla
notifications@github.comwrote:

[image: f96ef9026cc4353290b3407a45a12c34be9aecb2]https://f.cloud.github.com/assets/15370/38560/d38f784c-54f4-11e2-9b73-1fd864b7d920.png
Graph of the usable system memory for a memcache host before and after the
fix.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/278#issuecomment-11812629.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clofresh clofresh

Labels
checks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bciceron @clofresh @alq666 @olidb2