Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetes] Events from all namespaces #2838

Closed
rosskukulinski opened this issue Sep 12, 2016 · 6 comments
Closed

[kubernetes] Events from all namespaces #2838

rosskukulinski opened this issue Sep 12, 2016 · 6 comments

Comments

@rosskukulinski
Copy link

from #2551

Currently the Kubernetes events feature only gets events from the default namespace. This means that datadog is unable to capture critical events from the kube-system namespace as well as any other user-defined namespaces.

I believe the dd-agent kubernetes configuration should support two options:

  1. Capture events from all namespaces (defaults to False)
  2. Capture events from list of namespaces (defaults to default only)

This will not change the functionality of new 5.9 deployments but will enable improved kubernetes support down the road for all users.

relevant code: https://github.com/DataDog/dd-agent/blob/master/checks.d/kubernetes.py#L362

@hkaj
Copy link
Member

hkaj commented Sep 13, 2016

Hi @rosskukulinski

Thanks for opening this issue. As @masci mentioned you can specify another namespace in the instance of kubernetes.yaml (to see how we use the namespace parameter, see: https://github.com/DataDog/dd-agent/blob/master/checks.d/kubernetes.py#L361)
Although it should be documented, and we should probably allow collecting events from all/several namespaces.

The options you suggest seem reasonable and we'll work on supporting them for the next release.

Thanks again

@hkaj hkaj added this to the 5.10.0 milestone Sep 13, 2016
@AndrewDryga
Copy link

+1

yannrouillard pushed a commit to yannrouillard/dd-agent that referenced this issue Sep 30, 2016
This change makes events collection not limited anymore to one namespace
thanks to the new option `collect_events_from_all_namespaces`.

Fixes DataDog#2838
yannrouillard pushed a commit to yannrouillard/dd-agent that referenced this issue Sep 30, 2016
This change makes events collection not limited anymore to one namespace
thanks to the new option `collect_events_from_all_namespaces`.

Fixes DataDog#2838
@olivielpeau
Copy link
Member

Moving to the 5.11 milestone, the merge window for 5.10 is closing soon and we still need to assess what solution would be best to allow collecting events from more than one namespace.

@olivielpeau olivielpeau modified the milestones: 5.11.0, 5.10.0 Oct 25, 2016
@alexouzounis
Copy link

To me, it looks like we can specify one namespace at a time https://github.com/DataDog/dd-agent/blob/master/checks.d/kubernetes.py#L426 .Hence we would need a dd agent per namespace to watch for events. Would it possible to get wildcard support ?

@hkaj
Copy link
Member

hkaj commented Nov 7, 2016

Yes @alexouzounis that's the plan (allowing a list of namespace and probably regex). It's still in our backlog but should be ready for 5.11

@alexouzounis
Copy link

Nice! Will keep an eye on it then ;)

hush-hush added a commit that referenced this issue Nov 15, 2016
The configuration key 'namespace' is renamed 'namespaces' so multiple
names can be specified (if present the old key will be added to the
'namespaces' list).

A new configuration key 'namespace_name_regexp' is added to allow
namespaces selection using regexp.

We now pull every event from Kubernetes and filter them the
namespace list.
hush-hush added a commit that referenced this issue Nov 15, 2016
The configuration key 'namespace' is renamed 'namespaces' so multiple
names can be specified (if present the old key will be added to the
'namespaces' list).

A new configuration key 'namespace_name_regexp' is added to allow
namespaces selection using regexp.

We now pull every event from Kubernetes and filter them the
namespace list.
hush-hush added a commit that referenced this issue Nov 21, 2016
Updating Kubernetes check to handle multiple namespaces fix #2838
@masci masci modified the milestones: 5.11.0, 5.12.0 Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants