Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More metrics from Kubernetes State API #3045

Closed
therc opened this issue Nov 23, 2016 · 4 comments
Closed

More metrics from Kubernetes State API #3045

therc opened this issue Nov 23, 2016 · 4 comments
Assignees
@hkaj
Labels
sdk-later

Comments

@therc
Copy link
Contributor

therc commented Nov 23, 2016

5.10 introduced new metrics from the kubernetes-state-metrics API.
There are still some in the API that haven't made it to DataDog, e.g.:

kube_pod_container_status_ready{container="dd-agent",namespace="kube-system",pod="dd-agent-0fv0y"} 1
kube_pod_container_status_restarts{container="dd-agent",namespace="kube-system",pod="dd-agent-0fv0y"} 0
kube_pod_container_status_running{container="dd-agent",namespace="kube-system",pod="dd-agent-0fv0y"} 1
kube_pod_container_status_terminated{container="dd-agent",namespace="kube-system",pod="dd-agent-0fv0y"} 0
kube_pod_container_status_waiting{container="dd-agent",namespace="kube-system",pod="dd-agent-0fv0y"} 0

kube_pod_container_requested_cpu_cores{container="kubedns",namespace="kube-system",node="10.X.Y.Z",pod="kube-dns-v20-juul3"} 0.1
kube_pod_container_requested_memory_bytes{container="kubedns",namespace="kube-system",node="ip-10.X.Y.Z",pod="kube-dns-v20-juul3"} 1.048576e+08

At least the restarts and the requested resources (as opposed to limits) are very interesting to us.

I guess one question is how to map the pod and container names into DataDog: separate tags or combined into one?
@masci masci added this to the 5.11.0 milestone Nov 24, 2016
@schasse
Copy link

schasse commented Dec 5, 2016

+1

therc pushed a commit to therc/dd-agent that referenced this issue Dec 9, 2016
Add state metrics for pods and containers
88e17d5 
Fixes part of DataDog#3045

 * Add mem/cpu requests and limits
 * Add container restarts
 * Add pod phase: Pending|Running|Succeeded|Failed|Unknown

Tests might fail because the prometheus protobuf.bin blob lacks the
resource limits added in kubernetes/kube-state-metrics#49
@therc therc mentioned this issue Dec 9, 2016
Merged
therc pushed a commit to therc/dd-agent that referenced this issue Dec 21, 2016
Add state metrics for pods and containers
98cf16e 
Fixes part of DataDog#3045

 * Add container mem/cpu requests (not limits, they'll be in state-metrics 0.4)
 * Add container restarts
 * Add pod phase check: Pending|Running|Succeeded|Failed|Unknown

Metrics that are not supported yet or not covered by the test protobuf.bin
are commented out.
@masci masci modified the milestones: 5.11.0, 5.12.0 Jan 24, 2017
@ojongerius
Copy link
Contributor

Is the plan to keep this as the meta issue for improvements?

@ojongerius ojongerius mentioned this issue Mar 2, 2017
Closed
@olivielpeau olivielpeau removed this from the 5.12.0 milestone Mar 8, 2017
@ahawkins
Copy link

I think #3305 dupes this.

@hkaj hkaj mentioned this issue Apr 18, 2017
Closed
@hkaj
Copy link
Member

hkaj commented May 30, 2017

this should be fixed now, we're also working on supporting kube-state-metrics v0.5

@hkaj hkaj closed this as completed May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hkaj hkaj

Labels
sdk-later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@masci @ahawkins @ojongerius @gmmeyer @schasse @olivielpeau @hkaj @therc