[mysql] use information_schema when < 5.6.0
#3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `performance_schema.threads` table is not available on MySQL < `5.6.0`. As a result, retrieving the slaves' statuses triggers the following error: ``` ProgrammingError: (1146, u"Table 'performance_schema.threads' doesn't exist") ``` This is a regression introduced by #2603
truthbk
approved these changes
Feb 15, 2017
| @@ -863,12 +863,17 @@ def _get_replica_stats(self, db): | |||
| self.warning("Privileges error getting replication status (must grant REPLICATION CLIENT): %s" % str(e)) | |||
| return {} | |||
|
|
|||
| def _get_slave_status(self, db, nonblocking=True): | |||
| def _get_slave_status(self, db, above_560): | |||
There was a problem hiding this comment.
should we keep the non-blocking optional parameter?
There was a problem hiding this comment.
Not sure what's the benefits in doing that. _get_slave_status is only called here and once.
There was a problem hiding this comment.
I'm not sure if that was added on a customer request, not specifically, but asking to make the check more performant. But you are correct, it's only holding the mutex once per check run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
performance_schema.threadstable is not available on MySQL <5.6.0. As a result, retrieving the slaves' statuses triggers thefollowing error:
This is a regression introduced by
#2603