Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix proxy skipping #3644

Merged
merged 1 commit into from
Jan 25, 2018
Merged

fix proxy skipping #3644

merged 1 commit into from
Jan 25, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jan 25, 2018

What does this PR do?

This makes requests correctly ignore environment-declared proxies.

Motivation

I encountered the bug

arbll
arbll approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@arbll arbll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ofek ofek merged commit 8dfb691 into master Jan 25, 2018
@ofek ofek deleted the ofek/fix-skip-proxy branch January 25, 2018 17:58
This was referenced Jan 25, 2018
Merged
Merged
@hush-hush hush-hush modified the milestones: 5.23.0, 5.22.0 Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbll arbll arbll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @arbll @hush-hush