Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis check failing on tags in config #515

Closed
clofresh opened this issue May 22, 2013 · 2 comments
Closed

redis check failing on tags in config #515

clofresh opened this issue May 22, 2013 · 2 comments
Assignees

Comments

@clofresh
Copy link
Contributor

    redisdb
    -------
      - initialize check class [OK]
      - instance #0 [ERROR]: TypeError("__init__() got an unexpected keyword argument 'tags'",)
      - instance #1 [ERROR]: TypeError("__init__() got an unexpected keyword argument 'tags'",)
      - Collected 0 metrics & 0 events

Must be a regression in 3.7.1 since data just stopped yesterday.

This is the yaml file:

init_config:

instances:
    -   host: localhost
        port: 6379
        tags: [livecache, partitions:8-15]
    -   host: localhost
        port: 6380
        tags: [queue]
@clofresh
Copy link
Contributor Author

Full stack trace:

2013-05-22 05:41:35,704 | ERROR | dd.collector | checks.redisdb(__init__.py:454) | Check 'redisdb' instance #1 failed
Traceback (most recent call last):
  File "/usr/share/datadog/agent/checks/__init__.py", line 445, in run
    self.check(instance)
  File "/usr/share/datadog/agent/checks.d/redisdb.py", line 150, in check
    self._check_db(instance,custom_tags)
  File "/usr/share/datadog/agent/checks.d/redisdb.py", line 101, in _check_db
    conn = self._get_conn(instance)
  File "/usr/share/datadog/agent/checks.d/redisdb.py", line 93, in _get_conn
    self.connections[key] = redis.Redis(**instance)
TypeError: __init__() got an unexpected keyword argument 'tags'

@remh
Copy link
Contributor

remh commented May 22, 2013

I know what the issue is will fix as soon as I'm here
On May 22, 2013 10:02 AM, "Carlo Cabanilla" notifications@github.com
wrote:

redisdb
-------
  - initialize check class [OK]
  - instance #0 [ERROR]: TypeError("__init__() got an unexpected keyword argument 'tags'",)
  - instance #1 [ERROR]: TypeError("__init__() got an unexpected keyword argument 'tags'",)
  - Collected 0 metrics & 0 events

Must be a regression in 3.7.1 since data just stopped yesterday.

This is the yaml file:

init_config:

instances:
- host: localhost
port: 6379
tags: [livecache, partitions:8-15]
- host: localhost
port: 6380
tags: [queue]


Reply to this email directly or view it on GitHubhttps://github.com//issues/515
.

@ghost ghost assigned remh May 22, 2013
@remh remh closed this as completed in 08242df May 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants