Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent restart does not do configtest and can silently fail #838

Closed
ssbarnea opened this issue Feb 21, 2014 · 2 comments
Closed

agent restart does not do configtest and can silently fail #838

ssbarnea opened this issue Feb 21, 2014 · 2 comments
Milestone

Comments

@ssbarnea
Copy link

agent restart does not do configtest and can silently fail.

@ssbarnea ssbarnea reopened this Feb 21, 2014
@remh
Copy link
Contributor

remh commented Feb 21, 2014

Hi @ssbarnea
Can you tell us more what bad configuration made the restart fail ?
The agent didn't start at all or just some integrations were not properly configured and didn't work.
Thanks!

@ssbarnea
Copy link
Author

That's quite easy to replicate, make a modification in one config file, something wrong and restart the agent. You will see nothing wrong on the console, that's misleading.

Instead, I propose this enhancement, to first run a configtest and to perform the restart only if configtest succeeds. This will improve the experience quite a lot.

Also, please add an alias name "configtest" for the "configcheck", nginx and other services are already using "confitest" and it's a shame not to reuse the same naming convention.

remh added a commit that referenced this issue Mar 6, 2014
@remh remh closed this as completed in d71cf96 Mar 6, 2014
@remh remh added this to the 4.2.x milestone Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants