Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riak security support #2389

Closed
wants to merge 2 commits into from
Closed

riak security support #2389

wants to merge 2 commits into from

Conversation

hamano
Copy link
Contributor

@hamano hamano commented Mar 28, 2016

I'ts nessessary when enable riak security.

@remh remh added this to the Triage milestone Jun 24, 2016
@remh
Copy link
Contributor

remh commented Jun 24, 2016

Thanks a lot for this ! (and sorry for the delay :( )
I think those settings would make more sense at the instance level instead of the init config level. Would it be possible to move them please ?

@irabinovitch
Copy link
Contributor

We should review if this is still relevant given the work being done in #2762

@hamano
Copy link
Contributor Author

hamano commented Sep 16, 2016

@remh moved settings.

hush-hush
hush-hush requested changes Feb 1, 2017
View reviewed changes
Copy link
Member

@hush-hush hush-hush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and once again sorry for the delay !

I added a minor comment on the configuration example. Except that things look good and ready to be merged.

conf.d/riak.yaml.example
@@ -2,6 +2,8 @@ init_config:

instances:
- url: http://127.0.0.1:8098/stats
# cacert: /path/to/ca.pem
# disable_cert_verify: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the default value in the code is False, could you use false in the configuration example ?

@hush-hush
Copy link
Member

Hello @hamano,

I have rebase you PR to allow CI to succeed and change the example in the configuration to merge it quickly upstream.

Thanks again for your contribution. If you have any comments feel free to add them to #3168.

@hush-hush hush-hush closed this Feb 2, 2017
@hush-hush hush-hush mentioned this pull request Feb 2, 2017
Merged
@gmmeyer gmmeyer modified the milestones: 5.12.0, Triage Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hush-hush hush-hush hush-hush requested changes

Assignees

@hush-hush hush-hush

Labels
checks community sdk-merge
Projects
None yet
Milestone
5.12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hamano @remh @irabinovitch @hush-hush @truthbk @gmmeyer