[mongo] Improve messaging&tags on MongoDB replset member state events #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change summarized a lot of changes that improve how leadership election events look in the mongodb service check: * The event title nowrefers to the explicit hostname if checking localhost * The title now calls the member state by its official name and gives an the expanded state description in the body. * Events are only generated if there is a previous, known, state. This elimilates a lot of events being generated whenever the dd-agent is restarted. * Events now come with a set of tags featuring the previous and current states in a form that can unambiguously be queried, as well as the replSet in question.
|
Tests are passing. Let's ship 🚢 . |
|
Yay, thanks for pushing this through, and sorry I missed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #2409.
Added
SERVICE_CHECK_NAMEclass variableTestMongoUnit:test_state_translationThanks again @antifuchs