[win32] plays well memory check timeouts #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When timing out, the memory check illegitimately returns `None` instead of an empty list, causing an error in the collector 馃拃.. ``` 2016-05-17 15:19:23 Pacific Daylight Time | WARNING | checks.collector(win32.pyc:148) | Timeout while querying Win32_PerfRawData_PerfOS_Memory WMI class. Memory metrics will be returned at next iteration. 2016-05-17 15:19:23 Pacific Daylight Time | ERROR | checks.collector(collector.pyc:293) | Unable to fetch Windows system metrics. Traceback (most recent call last): File "checks\collector.pyc", line 286, in run TypeError: 'NoneType' object is not iterable ``` Fix it.
|
|
looks good!
gmmeyer
pushed a commit
that referenced
this pull request
Jun 17, 2016
[win32] plays well memory check timeouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When timing out, the memory check illegitimately returns
Noneinsteadof an empty list, causing an error in the collector 馃拃..
Fix it.