[http_check] Add allow_redirects parameter #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @n0ts thank you very much for this. This definitely looks like something we were missing. We'll review this in-depth soon (although it already looks good - thanks for the test), and we hope to merge it soon. Thanks! |
| @@ -243,7 +244,8 @@ def _check(self, instance): | |||
| self.log.debug("Weak Ciphers will be used for {0}. Suppoted Cipherlist: {1}".format( | |||
| base_addr, WeakCiphersHTTPSConnection.SUPPORTED_CIPHERS)) | |||
|
|
|||
| r = sess.request('GET', addr, auth=auth, timeout=timeout, headers=headers, proxies=instance_proxy, | |||
| r = sess.request('GET', addr, auth=auth, timeout=timeout, headers=headers, | |||
| proxies=instance_proxy, allow_redirects=allow_redirects, | |||
There was a problem hiding this comment.
In requests allow_redirects defaults to True as well so 👍 for the the default value as it maintains backward compatibility.
|
CI failures are unrelated, and this looks good to me! Especially with that test you wrote @n0ts Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I add allow_redirects parameter http_check. Because I want to check http status only 301 or 302.
Regards,