[flare] Add sd_configcheck output to flare command #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, only one remark: why not merge the default |
hkaj
force-pushed
the
haissam/add-sd_configcheck-to-flare
branch
from
10b566f
to
b23175f
Compare
hkaj
force-pushed
the
haissam/add-sd_configcheck-to-flare
branch
from
b23175f
to
894c100
Compare
|
good point @degemer ! Done, let me know what you think. |
|
Looks really nice now! 💯 |
gmmeyer
pushed a commit
that referenced
this pull request
Jun 17, 2016
gmmeyer
pushed a commit
that referenced
this pull request
Jun 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the flare command doesn't collect service discovery configcheck command, we need to run
/etc/init.d/datadog-agent configcheckexplicitely. It's a very useful command for investigating config issues so let's add it.