Use docker hostname instead of default route to query cadvisor & kubelet #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaj
force-pushed
the
haissam/fix-get-host-in-kubeutil
branch
from
69f145a
to
cc852d0
Compare
|
Looks good to me. Please squash before merging! Also, let's let CI go 💚 before merging. 👍 |
|
@hkaj 👍 for the test fixes! Nice. |
gmmeyer
pushed a commit
that referenced
this pull request
Jun 23, 2016
…let (#2609) * Use docker hostname instead of default route to query cadvisor & kubelet * remove is_dockerized condition from DockerUtil get_hostname
degemer
pushed a commit
that referenced
this pull request
Jul 6, 2016
…let (#2609) * Use docker hostname instead of default route to query cadvisor & kubelet * remove is_dockerized condition from DockerUtil get_hostname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the default route works fine in most cases, but if the user has a virtual network set up (like Calico) it won't point to the real host.
The docker host name is more reliable.
_get_default_routeris not used anywhere else, so I killed it.