[core][dogstatsd] Added support for IP agnostic connections #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
force-pushed
the
massi/dogstatsd_ipv6
branch
2 times, most recently
from
e066091
to
30392eb
Compare
masci
force-pushed
the
massi/dogstatsd_ipv6
branch
from
30392eb
to
c7efb11
Compare
masci
force-pushed
the
massi/dogstatsd_ipv6
branch
from
038f44e
to
6a833b0
Compare
| Map the host to an IPv6 address, trying to resolve the name | ||
| """ | ||
| try: | ||
| addr = socket.gethostbyname(host) |
There was a problem hiding this comment.
In the general case you'll be converting the ipv4 to ipv6 anyways - but maybe we should favor the ipv6 record if it exists. I'm saying this because the DNS might have the same name resolve to an A (ipv4) and an AAAA (ipv6) record, or furthermore just an ipv6 record.... So getaddrinfo might be a better option for dual-stack resolution - otherwise if the hostname only has an ipv6 record this might fail.
|
In general it looks good, just a couple open questions, and the DNS issue. Thanks a lot for splitting the tests, much, much cleaner and clear! 😍 |
masci
force-pushed
the
massi/dogstatsd_ipv6
branch
from
6a833b0
to
0accb2c
Compare
added 2 commits
June 24, 2016 17:48
|
This looks good! Good job 👍 |
truthbk
pushed a commit
that referenced
this pull request
Aug 10, 2016
* added support for IP agnostic dogstatsd * give precedence to IPv4 * updated docs [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Dogstatsd only listens to IPv4 connections, thus IPv6 clients aren't able to connect.
What
Now dogstatsd listens to an IP agnostic socket connection. IPv4 addresses are mapped to IPv6 to keep configuration file compatible with older versions.
While at the job: fixed tests, added tests and fixed PEP8 where possible.