[dogstatsd] fix server address when non_local_traffic is passed #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me |
degemer
added a commit
that referenced
this pull request
Jul 28, 2016
* master: (119 commits) [core] remove noisy logs (#2715) run multiple instances of pylint (#2716) [packaging] Release 5.8.5 (#2712) [changelog][5.8.5] Add notes on packaging changes (#2710) [changelog] Update 5.8.5 with python upgrade be more specific when logging ssh errors (#2708) [marathon] allow base_url with path (#2620) [changelog] Update 5.8.5 add issue and pr templates [sdk] minor tweaks - sdk env detection, check location (#2694) [http_check] log exceptions 🔊 use 0.0.0.0 as server address when non_local_traffic is passed (#2691) [elastic] tag stats metric with the node name 🏷 (#2696) [openstack] moving proxy logic to AgentCheck, for maintainability. Fixing typos. [changelog] 5.8.5 draft [tests] lower flakiness of test_no_parallelism (#2690) [core] don't use docker hostname if it's a EC2 one (#2661) [haproxy] Fix `KeyError` when an unknown status is found (#2681) [changelog] Fix md links [jenkins] Deprecate check (#2688) ...
truthbk
pushed a commit
that referenced
this pull request
Aug 10, 2016
|
What about multi-home systems that are on many networks? We want to explicitly set bind_host to listen on trusted networks and allow non_local_traffic, but now we have to work around this by using iptables or some set of security group rules. Shouldn't a setting called bind_host actually set the bind_host? We upgraded to agent 5.10 and was hit with this unpleasant surprise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to pass an empty string
''meaningany available interfacewhennon_local_trafficis present in the config file.This doesn't play well with the new code since we now use a unique, fullstack socket so we explicitly set the IPv4 meta address
0.0.0.0for retro compat.This leaves an open issue: it's not possible to start the agent with
non_local_trafficon an IPv6 only environment. For standalone Dogstatsd instances this is not a real issue, one can pass::asbind_host.