[kafka] bumping kafka-python package version to 1.2.5. #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[kafka] OffsetRequest is now OffsetRequestPayload [kafka] KafkaClient has changed location.
|
There will be a race condition when deploying between the agent's lib, and the custom check getting updated to use the new lib. |
|
Looks good to me, let's merge this along with its omnibus-software counterpart, build a custom package and deploy it on staging as we would do on prod |
|
omnibus-software PR: DataDog/omnibus-software#70 |
|
CI failures were unrelated to changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
Bumps the version of the kafka-python package.
Motivation
Improve support for newer kafka's.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
(none)