[RabbitMQ] new health check #2711
Merged
+101
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
force-pushed
the
massi/rabbit_check
branch
from
e868621
to
e360d9f
Compare
masci
force-pushed
the
massi/rabbit_check
branch
from
e360d9f
to
72adbd3
Compare
masci
force-pushed
the
massi/rabbit_check
branch
from
72adbd3
to
d768350
Compare
| check = RabbitMQ('rabbitmq', {}, {"instances": [{"rabbitmq_api_url": "http://example.com"}]}) | ||
| r.get.side_effect = [requests.exceptions.HTTPError, ValueError] | ||
| self.assertRaises(RabbitMQException, check._get_data, '') | ||
| self.assertRaises(RabbitMQException, check._get_data, '') |
There was a problem hiding this comment.
It's to consume all the side_effects so we test it both with HTTPError (would be ok any requests exception) and ValueError
|
Love the tests ❤️ ! This looks great to me, just one comment. Otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A new status check was added,
rabbitmq.statusthat reflects the status of the RabbitMQ service (up/down), which is different from the outcome of thealivenessstrategy that is still implemented by the existingrabbitmq.alivenessstatus check.Motivation
The aliveness check is misleading when the RabbitMQ service is down - an exception is raised and the check simply provides no data whilst the info command, along with the UI correctly report an issue for the integration.