[wmi] set provider architecture when necessary #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows 2008, setting a WMI provider would cause an exception. To prevent this from unecessarily happening, only proceed when the provided value is not set to the default one.
Datadog Agent checks do not necessarily inherit directly from the `AgentCheck` class. When it is the case, the `run_check` DEBUG method would fail loading the check. This happens with WMI checks for instance. Allow the `run_check` DEBUG method to load any agent check that inherits from the `AgentCheck`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[wmi] set provider architecture when necessary
On Windows 2008, setting a WMI provider would cause an exception.
To prevent this from unecessarily happening, only proceed when the
provided value is not set to the default one.
[debug] improve
run_checkcompatibilityDatadog Agent checks do not necessarily inherit directly from the
AgentCheckclass. When it is the case, therun_checkDEBUG methodwould fail loading the check.
This happens with WMI checks for instance.
Allow the
run_checkDEBUG method to load any agent check that inheritsfrom the
AgentCheck.