[core] Hostname logic refactoring #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remh
force-pushed
the
remh/hostname_logic
branch
from
53c10b7
to
ef5043d
Compare
|
Forgot to mention that it also switched the metadata collection from GCE and AWS to |
remh
force-pushed
the
remh/hostname_logic
branch
3 times, most recently
from
73a5539
to
ac1a1b0
Compare
| return config_hostname | ||
|
|
||
| # Try to get GCE instance name | ||
| if hostname is None: |
There was a problem hiding this comment.
ha good point, it was the old logic though that just got moved but yeah
|
It looks way better now ! 🍰 Only nitpicks, looks good otherwise. |
remh
force-pushed
the
remh/hostname_logic
branch
from
ac1a1b0
to
4adcee9
Compare
This commit: - Moves hostname logic in it’s own util module - Moves cloud metadata logic in it’s own util module - Add a new way to determine the hostname using the kubelet - Some code cleaning/consolidating
|
Fixed the nitpicks |
|
Tests are failing on the bad ES tests, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR:
Motivation
Needed to have another way to find the hostname when running kubernetes but i realized that this logic could benefit from refactoring so i did.