Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the env var KUBERNETES_SERVICE_HOST if present #2921

Merged
merged 1 commit into from Oct 18, 2016

Conversation

arohner
Copy link
Contributor

@arohner arohner commented Oct 17, 2016

Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.

What does this PR do?

In the kubernetes check, use the env var KUBERNTES_SERVICE_HOST to specify the API endpoint, if present.

Motivation

See #2551 (comment) . When using dd-agent in namespaces such as kube-system, the kube-dns service might not be running, so the kubernetes host might not be present.

Copy link
Member

@hkaj hkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arohner ! You're right, we should avoid relying on extensions as much as possible.

@hkaj hkaj merged commit da1d8e7 into DataDog:master Oct 18, 2016
@olivielpeau olivielpeau added this to the 5.10.0 milestone Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants