Logging

[xcolour]

Comprehensive logging reform.

[clofresh]

Pretty sure we wanted this removed (3073c60)

[xcolour]

Ha, I'm even the one who removed it.

[clutchski]

In general, I don't really like getLogger(get_logger_name). It's a pretty well known convention in Python land to do getLogger(__name_). Instead of always using the same logger everywhere, why not one FileHandler for each component which points to the right file, and then a small step in the initialization of each app that attaches that handler to the root logger. Then we don't lose the module name in the log lines. Does that make sense?

[clutchski]

@xcolour we should merge this this week, so that is goes with the next agent release.

[alq666]

@xcolour @clutchski using papertrail to gauge volume, 5-10% of syslog is non-agent log entries.

Jan 04 15:53:25 10.10.54.223 ntpd:  kernel time sync status change 2001

# then a ton of 
Jan 04 15:53:25 10.10.54.223 dd-agent:  - collector - INFO - Starting collection run #4324
Jan 04 15:53:31 10.10.54.223 dd-agent:  - collector - INFO - Finished run #4324. Collection time: 5.86s. Emit time: 0.01s
Jan 04 15:53:46 10.10.54.223 dd-agent:  - collector - INFO - Starting collection run #4325
Jan 04 15:53:52 10.10.54.223 dd-agent:  - collector - INFO - Finished run #4325. Collection time: 5.66s. Emit time: 0.01s
Jan 04 15:54:07 10.10.54.223 dd-agent:  - collector - INFO - Starting collection run #4326
Jan 04 15:54:13 10.10.54.223 dd-agent:  - collector - INFO - Finished run #4326. Collection time: 5.75s. Emit time: 0.01s
Jan 04 15:54:28 10.10.54.223 dd-agent:  - collector - INFO - Starting collection run #4327
Jan 04 15:54:33 10.10.54.223 dd-agent:  - collector - INFO - Finished run #4327. Collection time: 5.66s. Emit time: 0.01s
Jan 04 15:54:48 10.10.54.223 dd-agent:  - collector - INFO - Starting collection run #4328

Rather, can we post stats about runs every 20 runs (once every 5-10 mins), or when there is an exception during the run?

[conorbranagan]

@xcolour I merged master into this branch and fixed up the conflicts so it should be good to merge (if travis passes). I'd like to get this into the next release if possible.

[conorbranagan]

Fixed up some issues that I didn't catch with the merge. It's running on dogdev0 but it still hasn't gotten through travis. I'll keep an eye on it to see what happens. It looks like travis is pretty backed up today so it might be a while.

[conorbranagan]

Travis is finally passing (the last commit had 1/3 pass because 2 of the builds got stalled) so I'm going to merge now.