Allow source file and line in Cassandra system.log. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@remh Can you take a look at this? |
|
sure |
remh
added a commit
that referenced
this pull request
Dec 19, 2012
Seems fine. Merging it. Thanks @shawnsmith !
|
Does it work for both syslog and file log formats? |
|
yes |
|
@shawnsmith We'll plan to release this in 3.4.3, the week of New Year's Day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For logging Cassandra compaction events:
This pull request updates the Cassandra dogstream parser to support Cassandra's default log4j pattern for
/var/log/cassandra/system.log:The previous dogstream regular expression appears to work for
stdoutbut does not expect the%F (line %L)piece configured forsystem.log.To enable, add the following to /etc/dd-agent/datadog.conf: