Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Remove system network check. Network check was added as #3096

Merged
merged 1 commit into from
Mar 31, 2017

Conversation

derekwbrown
Copy link
Contributor

checks.d/network. This check is redundant, and causing confusing returns
as the same metric is being reported from two different places.

Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.

What does this PR do?

Removes the Network check from the system checks.

Motivation

While debugging/testing a separate code change, found that two different checks were reporting the same metric, and this was causing confusing data.

checks.d/network. This check is redundant, and causing confusing returns
as the same metric is being reported from two different places.
Copy link
Member

@degemer degemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "confusing data"? Value was not correct? Or tags?
I think we'll have to do it anyway, but what will the customer impact be?

@truthbk truthbk added this to the 5.12.0 milestone Feb 22, 2017
@gmmeyer gmmeyer modified the milestones: 5.13.0, 5.12.0 Mar 8, 2017
@derekwbrown derekwbrown merged commit 6fe9cc9 into master Mar 31, 2017
@masci masci modified the milestones: 5.13.0, 5.14.x Apr 12, 2017
@derekwbrown derekwbrown deleted the dbrown/remove_system_network_check branch April 13, 2017 20:21
@truthbk truthbk modified the milestones: 5.13.0, 5.14 Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants