Add ability to get docker IP address from Rancher labels for Rancher 1.3 #3265
Conversation
|
Nice one @zippolyte This way users will be able to graph their metrics based on rancher resources. |
| @@ -171,6 +171,14 @@ def _get_host_address(self, state, c_id, tpl_var): | |||
| if pod_ip: | |||
| return pod_ip | |||
|
|
|||
| # try to get the rancher IP address | |||
| log.debug("No IP address was found in container %s (%s) " | |||
There was a problem hiding this comment.
Could you add if Platform.is_rancher() before this new code? Otherwise this rancher-specific log line will show up in non Rancher environments.
You'll need to create an is_rancher function in platform.py first. One way you could detect rancher is by looking for their agent container(s) (read more about that here).
| @@ -290,6 +301,12 @@ def get_tags(self, state, c_id): | |||
| if swarm_svc: | |||
| tags.append('swarm_service:%s' % swarm_svc) | |||
|
|
|||
| if Platform.is_rancher(): | |||
| c_inspect = state.inspect_container(c_id) | |||
| service_name = c_inspect.get('Config', {}).get('Labels', {}).get('io.rancher.container.name') | |||
There was a problem hiding this comment.
maybe make io.rancher.container.name a constant? It could live here or in dockerutil.
| log.debug("No IP address was found in container %s (%s) " | ||
| "trying with the Rancher label" % (c_id[:12], c_img)) | ||
|
|
||
| ip_addr = c_inspect.get('Config', {}).get('Labels', {}).get('io.rancher.container.ip') |
There was a problem hiding this comment.
maybe make io.rancher.container.ip a constant?
|
cool, i like it better too :) |
edit by hkaj: linked with DataDog/integrations-core#282