Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][emitter] Force source type to system for legacy payload #3280

Merged
merged 2 commits into from
Mar 23, 2017

Conversation

remh
Copy link
Contributor

@remh remh commented Mar 23, 2017

What does this PR do?

This PR forces source type to "system" for the payload split in the emitter

Motivation

Otherwise this will churn contexts as they'll have a different source type name. This can also lead to transient double counting.

@remh remh added this to the 5.12.1 milestone Mar 23, 2017
Copy link
Member

@Arkelenia Arkelenia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know enough the agent to check if it fixes this bug perfectly but the new field you added is exactly what needs to be sent on every point on the new payload. LGTM 👍

@truthbk truthbk added the bugfix label Mar 23, 2017
@remh remh merged commit 00bed41 into master Mar 23, 2017
@olivielpeau olivielpeau deleted the remh/emittercontext branch March 23, 2017 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants