RabbitMQ Management Plugin Check #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this check is used to gather statistics from RabbitMQ's managment plugin
|
Apache Tomcat mirror is broken, causing travis to fail. Using |
| @@ -0,0 +1,81 @@ | |||
| import json | |||
There was a problem hiding this comment.
If you do from util import json instead it will support more version of python because we handle simplejson, stdlib json, etc.
There was a problem hiding this comment.
Thank you, I also noticed there is checks.libs.httplib2 is this preferred over urllib2?
There was a problem hiding this comment.
Using urllib2 here is fine. We used httplib2 for one check so that timeouts would be compatible with versions >= 2.4, but that's not needed in this case, as far as I can tell.
|
Thanks for the pull. 👍 |
conorbranagan
added a commit
that referenced
this pull request
Jan 8, 2013
RabbitMQ Management Plugin Check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the RabbitMQ Status plugin is no longer supported, this check is used to gather statistics from RabbitMQ's managment plugin by using the /api endpoint.
I have only tested this with RabbitMQ 3.0.1.