[kubernetes] catch errors from kubeutil init #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
approved these changes
Apr 19, 2017
| @@ -89,8 +89,11 @@ def __init__(self, agentConfig): | |||
|
|
|||
| self.docker_client = DockerUtil(config_store=self.config_store).client | |||
| if Platform.is_k8s(): | |||
| self.kubeutil = KubeUtil() | |||
There was a problem hiding this comment.
nit: should we assign self.kubeutil = None in case the exception is raised, to avoid attribute errors later?
There was a problem hiding this comment.
Actually it could be an issue, we would have an error later accessing self.kubeutil
hkaj
force-pushed
the
haissam/catch-kubelet-error
branch
from
90a09aa
to
9e9e967
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
Kubeutil raises an exception if it can't reach the kubelet. We should catch it.
Motivation
Ugly collector logs
Testing Guidelines
Run the agent on a non-k8s node, see that the exception is now caught.
Additional Notes
sister PR: DataDog/integrations-core#345