[docker] fix net metrics in host mode #3313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
If a container is in host mode we shouldn't call
socket.inet_aton
on its network gateway because it's empty and will fail, resulting in a warning in the integration. We can't not report the metrics either because existing behavior reports network metrics even in host mode (so network metrics are actually for the whole host). So let's keep the same behavior but avoid the buggy call to inet_aton.Motivation
Getting rid of a warning.
Testing Guidelines
Run the agent in host mode (or any other container on the same machine), see that the warning disappeared compared to the RC, replaced with a debug log.