Rename library from wmi_check.py -> winwmi_check.py as the class that it #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provides is WinWMICheck, and having the name wmi_check.py was confusing the python check loader in agent6 between this file and wmi_check.py (the actual check). However, since the checks are shared (integrations-core) the corresponding change has to be made here
This was referenced Sep 14, 2017
Fix the import statement in the test so tests will pass
olivielpeau
reviewed
Sep 15, 2017
checks/wmi_check.py
Outdated
| # | ||
| # this file will be deprecated in Agent6 | ||
| from checks.winwmi_check import ( | ||
| InvalidWMIQuery, |
There was a problem hiding this comment.
you're missing one import for full BC: WMIMetric
derekwbrown
force-pushed
the
db/wmi_check_ambiguity
branch
2 times, most recently
from
b1e9243
to
74883ad
Compare
derekwbrown
force-pushed
the
db/wmi_check_ambiguity
branch
from
74883ad
to
1c3eaef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provides is WinWMICheck, and having the name wmi_check.py was
confusing the python check loader in agent6 between this file and wmi_check.py (the
actual check). However, since the checks are shared (integrations-core)
the corresponding change has to be made here
Requires 3 PRs to go in together
DataDog/integrations-core#752
DataDog/datadog-agent#568
#3521