Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
By default, the Tornado HTTP Client (either the simple client or the curl client) in the forwarder will use IPv6 if it is available. Sometimes users wish to force the agent to use IPv4. This PR adds a config option that allows users to force the forwarder's HTTP client to use IPv4.
Motivation
This feature has been requested by several customers.
Testing Guidelines
Test strategy:
On a network that support IPv6:
allow_ipv6: no
in the agent configuse_curl_http_client: yes
in the agent configThe curl client persists connections after each request, so I could see which IP version it was using with
lsof -i -a -p $(pgrep -f ddagent.py)
(it also logs the IPs it's using). The simple client does not persist connections, but I could check the IPs it was connecting to withstrace -p $(pgrep -f ddagent.py) -f -e trace=network -s 10000
.The agent behaved as expected in these tests.