[filehandles] Include allocated, allocated but unused, used, and max filehandler metrics #3608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change emits more file handler metrics that weren't previously available: num allocated, num allocated but unused, used (an alias for allocated - allocated and unused), and max num of file handles.
Motivation
The "% of max file handlers used" metric introduced by #3395 helps us detect changes in file handler usage, but sometimes I want to know the absolute values (ex: when comparing different hosts with different limits).
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
I verified this by running the agent on my host and seeing the new metrics in the Datadog web UI.