[dockerutil] logs info if Dockerless #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaj
reviewed
Feb 7, 2018
utils/dockerutil.py
Outdated
| "will fail. Will retry %s time(s). Error: %s" % (self.left_init_retries, str(ex))) | ||
| # No docker_daemon.yaml + no existing Docker socket file = Dockerless | ||
| if self._no_conf_file and not os.path.isfile(DEFAULT_SOCK_PATH): | ||
| log.info("No docker_daemon conf and no Docker instance detected.") |
There was a problem hiding this comment.
Should we add the # of retries left to the message? Something like "No docker_daemon conf and no Docker instance detected, will retry %s time(s) before disabling docker features" % self.left_init_retries
There was a problem hiding this comment.
We could but, without the docker_daemon conf, it will always retry 0 times right? What if we go ahead and say that Docker features have been disabled.
"No docker_daemon conf and no Docker instance detected. Docker features disabled."
|
All good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Logs an INFO message instead of an ERROR when the host is deemed as Dockerless.
Basically, if there was no docker_daemon.yaml file detected, assume that a running Docker instance will use a default socket file /var/run/docker.sock. If both the yaml file and the socket file do not exist, then the host is Dockerless; raise an INFO instead of an ERROR so as not to alarm customers.
Motivation
A question often asked by (new) support engineers and customers.