[windows] change default datatype for pdh queries to double. Integer #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loses fidelity, especially with values between 0 and 1.
derekwbrown
force-pushed
the
db/pdhfloat
branch
from
39960e4
to
e9d88b6
Compare
truthbk
reviewed
Mar 15, 2018
| except ImportError: | ||
| from checks.libs.win.winpdh_stub import WinPDHCounter | ||
| from checks.libs.win.winpdh_stub import WinPDHCounter,DATA_TYPE_INT, DATA_TYPE_DOUBLE |
There was a problem hiding this comment.
I don't think DATA_TYPE_INT, DATA_TYPE_DOUBLE has been defined in the stub.
derekwbrown
force-pushed
the
db/pdhfloat
branch
from
f7f80f1
to
89a9cb4
Compare
truthbk
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loses fidelity, especially with values between 0 and 1.
What does this PR do?
change default pdh counter precision to float from int.
Allows configuration to set specific counter types
Motivation
customer request